-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 API proposal #42
Comments
The issue regarding the proposal for 2.0 is as follows. We can either run with the current version of Or we could wait until the NAPI version of Although the issue with releasing now is, the changes that will come with updating to the NAPI The issue with waiting for the NAPI version is that there would be a fairly long wait until NAPI is stable and ready to be used on production. To use NAPI modules they require the NAPI flag to add the dependency. Which would strike as an issue when installing So I need opinions on what way we should take this. @dfcreative @jamen 😄 |
Hey. So I'm all up for using I'll let you make the decision on where to invest your time, though. |
As for me I would choose getting things done rather than perfectly undone. That is if we can release this API within one-day effort but with But we have always to be open to refactoring, ie. breaking API later to allow for |
Cool, I'll get it released for |
Do we still want the browser implementation in 2.0? @dfcreative @jamen |
@connorhartley yes, but I can take care of it |
@dfcreative If you would like to make some tests for it that would be sweet! I am working in the release-2.0-browser branch, should be nearly ready. 😄 |
@connorhartley I've added minimal easy-peasy test for browser and covered browser implementation here 944f254. |
Thank you very much @dfcreative ! |
Any chance I can test this out? I'm building an Electron app w/ node for streaming Amazon Polly speech mp3's |
@iwasrobbed That sounds awesome, feel free to keep us updated! There is a pull request open at #44 where most of this is implemented already, if I'm not mistaken. I think the concern at the moment is how stable #44 actually is, I think we need more extensive testing, but I'm unable to check this at the moment (more could have been added since I've looked at it) @connorhartley @dfcreative, what else needs to be done to wrap this up? 😄 (P.S., if you are decoding with audio.js too, you might also want to see audiojs/audio-decode#2) |
Thanks @jamen ; I gave it a quick test drive (Mac OS X Sierra), but doesn't seem quite ready yet:
Let me know if I can help test when you're ready and happy to do so |
@iwasrobbed |
Ideally API should be
Stream counterparts are
audio-speaker-stream
andpull-audio-speaker
The text was updated successfully, but these errors were encountered: