Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear copy #70

Open
computersarecool opened this issue Mar 4, 2017 · 1 comment
Open

Unclear copy #70

computersarecool opened this issue Mar 4, 2017 · 1 comment

Comments

@computersarecool
Copy link

computersarecool commented Mar 4, 2017

This guide writes:

Is it true that favicons should be in the site root? No, that's only if you don't explicitly specify the browser/device-specific tags with a favicon path. See https://en.wikipedia.org/wiki/Favicon.ico.

But the goes on to say:

If you don't have favicon.ico in the root consider adding one, or returning a HTTP 204 instead.

I find this confusing. Should there be a favicon in the root or not? Can this be clarified?

@nathanhornby
Copy link

nathanhornby commented Jul 10, 2017

Just replace the word 'should' in the first quote with 'must'.

MUST the favicon be in the root? No, but if it's not you'll need to tell the browser where it is or return an error code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants