Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsertInterface purpose? #92

Closed
pavarnos opened this issue May 10, 2016 · 2 comments
Closed

InsertInterface purpose? #92

pavarnos opened this issue May 10, 2016 · 2 comments

Comments

@pavarnos
Copy link
Contributor

Hi

I'm not understanding InsertInterface (and some of the other interfaces): they appear to be to be incomplete?

I'd like my code to depend on the interfaces rather than the concrete classes of Aura.SqlQuery but the interfaces are often missing useful methods. eg Common\Insert implements addRow() and addRows() but these are not in InsertInterface... is there a good reason for that?

@pmjones
Copy link
Member

pmjones commented Sep 2, 2016

The problem in this case is that "bulk inserts" were added after InsertInterface went stable. In order to maintain BC, we can't change a stable interface to add methods, because that would break anyone else's implementation of the interface -- they would have to add the new methods to previously-running code. We can only add those methods to the interface in a major version release.

@pavarnos
Copy link
Contributor Author

see also #108. Would be good to add the new reset*() methods too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants