Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurelia-templating update causes a compile issue in patches.d.ts. #9

Closed
OtherLeadingBrand opened this issue Apr 7, 2022 · 2 comments

Comments

@OtherLeadingBrand
Copy link

A recent update to aurelia-templating appears to have created a compile time issue with this library:

node_modules/aurelia-typed-observable-plugin/dist/types/patches.d.ts:8:9 - error TS2717: Subsequent property declarations must have the same type.  Property 'name' must be of type 'any', but here has type 'string'.

8         name: string;
          ~~~~

  node_modules/aurelia-templating/dist/types/aurelia-templating.d.ts:1568:2
    1568  name: any;
          ~~~~
    'name' was also declared here.

As evidenced in the error message, aurelia-templating is now defining BindableProperty.Name as an any instead of a string.

It appears to be due to this change in the aurelia-templating library made to handle this vulnerability issue in the aurelia-framework:

@bigopon
Copy link
Collaborator

bigopon commented Apr 7, 2022

@OtherLeadingBrand thanks for reporting the issue. I'll be having a fix for this soon.

@bigopon
Copy link
Collaborator

bigopon commented Apr 10, 2022

@OtherLeadingBrand version 0.5.0 that contains the fix for this has been published to npm. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants