-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Out of stack space" error in IE 11 #843
Comments
If I remember correctly, this error is only caused by missing Polyfills... I remember hitting this few months ago... Adding aurelia-polyfills fix it. I'm surprised the CLI doesn't include them by default. |
Same issue here. This is breaking our project. After adding This is the "devDependencies": {
"@babel/core": "^7.4.3",
"@babel/polyfill": "^7.4.3",
"@babel/preset-env": "^7.4.3",
"@types/node": "^11.13.0",
"@types/webcomponents.js": "^0.6.34",
"@webcomponents/webcomponentsjs": "^2.2.7",
"babel-loader": "^8.0.5",
"class-validator": "^0.9.1",
"clean-webpack-plugin": "^2.0.1",
"css-loader": "^2.1.1",
"file-loader": "^3.0.1",
"json-server": "^0.14.2",
"lit-html": "^1.0.0",
"node-sass": "^4.11.0",
"sass-loader": "^7.1.0",
"style-loader": "^0.23.1",
"ts-loader": "^5.3.3",
"typescript": "^3.4.1",
"url-loader": "^1.1.2",
"webpack": "^4.29.6",
"webpack-cli": "^3.3.0",
"webpack-dev-server": "^3.2.1"
} Our entry file starts like this: // Helps making custom elements compatible with IE11 and evergreen browsers.
import "@webcomponents/webcomponentsjs/webcomponents-bundle";
import "@webcomponents/webcomponentsjs/custom-elements-es5-adapter.js";
import "@babel/polyfill" The
Our
And the Babel part of our {
test: /\.js$/i,
include: [
/[/\\]node_modules[/\\]lit-html[/\\]/i
],
use: {
loader: 'babel-loader',
options: {
presets: ['@babel/preset-env']
}
}
} This is the function that's infinitely calling itself: |
Please try #1080, it should get rid of babel/polyfill and core-js related issue. |
Currently core-js v3 is having some issue on IE. zloirock/core-js#496 (comment) |
@huochunpeng: Would you mind elaborating on the steps you want me to perform? I'm not sure I know how to integrate your PR into our project and check for the differences. |
If you use webpack, update webpack.config.js new ProviderPlugin({
// Add this line
'Promise': ['promise-polyfill', 'default']
}) If you use cli built-in bundler, update aurelia.json "prepend": [
// Add this line before requirejs/systemjs/alameda
"node_modules/promise-polyfill/dist/polyfill.min.js",
"node_modules/requirejs/require.js"
] |
I did as you suggested:
Yet, the polyfills are not used then. So, unfortunately, no success, I'm afraid. |
aurelia-polyfills covered it. aurelia-polyfills is loaded by aurelia-bootstrapper at first line of code. What's your new error in IE11? |
@huochunpeng: I believe I made a terrible mistake here: I'm not using Aurelia. I'm using bare Babel ... I'm wrong here, ain't I ..? 😢 😊 |
😆 however, you can use promise-polyfill + aurelia-polyfills if babel's offering does not work for you. |
That solution works for me:
|
Latest cli does all of those. I will close this one. |
for reference
Cli setup with webpack and babel has the same error in IE 11
as in this issue with skeletons
aurelia/skeleton-navigation#821
The text was updated successfully, but these errors were encountered: