You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current behavior:
When the casing of root (which is the baseUrl passed on from the router) does not match to current root, the application fails to navigate to any route.
What is the expected behavior?
Navigation should not rely on exact casing of the root.
What is the motivation / use case for changing the behavior?
The route-recognizer is case-insensitive (with an option to specify individual routes as case-sensitive, see Case sensitive router router#271). The baseUrl should probably have similar behaviour, or at least have an option to specify it as case-insensitive.
As far as I could tell, there are two places in history-browser that are affected:
This will not cope with various unicode characters etc.
Should consider using localeCompare() instead. Unsure whether sensitivity: base or sensitivity: accent would be more appropriate for a URI - I'm guessing accent?
Is there any case where we would want to enfore case-sensitivity? (i.e. should this be opt-in functionality?)
Is this still relevant in the latest history-browser version?
Any other areas of the code that might need to account for case (in)sensitivity?
I'm submitting a bug report
Library Version:
1.3.0
Browser:
all
Language:
all
Current behavior:
When the casing of root (which is the baseUrl passed on from the router) does not match to current root, the application fails to navigate to any route.
What is the expected behavior?
Navigation should not rely on exact casing of the root.
What is the motivation / use case for changing the behavior?
The route-recognizer is case-insensitive (with an option to specify individual routes as case-sensitive, see Case sensitive router router#271). The baseUrl should probably have similar behaviour, or at least have an option to specify it as case-insensitive.
As far as I could tell, there are two places in history-browser that are affected:
history-browser/src/index.js
Lines 240 to 242 in ba889f8
history-browser/src/index.js
Line 71 in ba889f8
The text was updated successfully, but these errors were encountered: