Pluses get replaced with spaces

[MaximBalaganskiy]

I'm submitting a bug report

• Library Version:
  1.1.3

Please tell us about your environment:

• Operating System:
  Windows 10

• Node Version:
  8.9.4

• NPM Version:
  6.9.0

• JSPM OR Webpack AND Version
  webpack 4.30.0

• Browser:
  all

• Language:
  all

Current behavior:
Passing + in a url parameter results in an argument to activate function where + is replaced with [space]

Expected/desired behavior:

• What is the expected behavior?
  + is passed as is

• What is the motivation / use case for changing the behavior?
  Previously, a path would be passed unencoded which correctly translated to view parameters. Now, when the + appears in the path, the line

  path/src/index.js

  Line 229 in 0be13f7

  let pairs = query.replace(/\+/g, ' ').split('&');

  replaces it with a space.
  This breaks scenarios with Asp.Net Identity password reset codes for example.

[MaximBalaganskiy]

The bug "works" together with the following line
https://github.com/aurelia/history-browser/blob/064575c45ba138535708ef0a15d395f7a6df2fff/src/browser-history.ts#L276

[thomas-darling]

This is a major problem when encoding ISO date strings, where the UTC offset is specified with a plus or minus sign...
A fix for it would be much appreciated 🙂