Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ComponentTester): import missing waitFor function #60

Merged
merged 1 commit into from
Mar 21, 2017
Merged

fix(ComponentTester): import missing waitFor function #60

merged 1 commit into from
Mar 21, 2017

Conversation

shanonvl
Copy link
Contributor

Fixes #59

  • Resolves issue when using ComponentTester.waitForElement(s)
  • Started a ComponentTester spec; implemented methods that verify
    this fix.

@shanonvl
fix(ComponentTester): import missing waitFor function
8d22b7a 
- Resolves issue when using ComponentTester.waitForElement(s)
- Started a ComponentTester spec; implemented methods that verify
this fix.
MeirionHughes
MeirionHughes reviewed Mar 20, 2017
View reviewed changes
Copy link

@MeirionHughes MeirionHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@EisenbergEffect EisenbergEffect merged commit 1ecfbfe into aurelia:master Mar 21, 2017
@shanonvl shanonvl deleted the fix/waitfor-is-not-defined branch March 21, 2017 14:22
@MeirionHughes MeirionHughes mentioned this pull request Mar 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeirionHughes MeirionHughes MeirionHughes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when calling ComponentTester.waitForElement(s)
3 participants
@shanonvl @MeirionHughes @EisenbergEffect