Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typescript type of .tag() from string to any #352

Closed
jsobell opened this issue Sep 29, 2016 · 3 comments
Closed

Change typescript type of .tag() from string to any #352

jsobell opened this issue Sep 29, 2016 · 3 comments

Comments

@jsobell
Copy link
Contributor

jsobell commented Sep 29, 2016

The tag field is associated with a rule, so there's not really any need specify it as a string, as it can also be used to associate metadata with a rule.
@dkent600 wants to pass a list of associated properties to his renderer for object level rules, and of course this can also apply to property linked rules if they have (v.obj) => obj.anotherProperty==true.
If we leave it as type any it can also be used for its original intention but with more advanced filtering.

This also (I think) covers #279 (comment) and #351

@dkent600
Copy link
Contributor

@jsobell Can you please give an example of how a developer would use this to address 279 (comment) and #351?

Thanks

@jdanyow
Copy link
Contributor

jdanyow commented Sep 29, 2016

I don't think tag will solve the two issues but keeping this open for non-string tags.

@jdanyow
Copy link
Contributor

jdanyow commented Nov 30, 2016

Closing- there are some data-binding capabilities I want to add that would enable binding to the validity of a tagged rule. Keeping the tag arg a string will make this easier/more-consistent.

@jdanyow jdanyow closed this as completed Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants