Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better mechanism for capturing gas usage in benchmarks #45

Closed
birchmd opened this issue Apr 28, 2021 · 2 comments
Closed

Better mechanism for capturing gas usage in benchmarks #45

birchmd opened this issue Apr 28, 2021 · 2 comments
Labels
C-enhancement Category: New feature or request C-good-first-issue Category: Good for newcomers P-low Priority: low

Comments

@birchmd
Copy link
Member

birchmd commented Apr 28, 2021

In #41 gas usage of the benchmarks is simply reported to the terminal. This makes capturing the data and analyzing it a manual process, which is sub-optimal.

The goal of this issue is to find a better way to capture the gas usage data, and to combine it with the timing data automatically in order to draw conclusions.

One possibility might be to use a custom measurement in criterion itself.
@birchmd birchmd added the C-enhancement Category: New feature or request label Apr 28, 2021
@artob
Copy link
Contributor

artob commented Apr 30, 2021

Related PR in the works: #48

@artob artob added the C-good-first-issue Category: Good for newcomers label Jun 6, 2021
@joshuajbouw joshuajbouw added the P-low Priority: low label Jul 2, 2021
@joshuajbouw
Copy link
Contributor

Can close as of #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: New feature or request C-good-first-issue Category: Good for newcomers P-low Priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@artob @joshuajbouw @birchmd