Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages in separate modules #547

Open
sept-en opened this issue Jul 4, 2022 · 0 comments
Open

Error messages in separate modules #547

sept-en opened this issue Jul 4, 2022 · 0 comments
Labels
C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@sept-en
Copy link
Contributor

sept-en commented Jul 4, 2022

This is a follow-up on #535 where constant error messages were introduced. The suggestion is also to separate these errors logically into appropriate modules. This will allow selecting the right error for a given scope of the code and ensuring that "foreign" errors are not used where they are not intended to be used.

Some ideas of such modues:

  • evm module: e.g. errors::evm::ERR_OUT_OF_GAS;
  • json module: e.g. errors:json::ERR_NOT_A_JSON_TYPE;
  • etc.
@sept-en sept-en added the C-housekeeping Category: Refactoring, cleanups, code quality label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

No branches or pull requests

1 participant