build: only use borsh re-exported by near-sdk
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooori
changed the title
borsh re-exported by near-sdk
birchmd
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Aurora Engine uses udeps to catch unused Cargo dependencies. Maybe it makes sense to add it to CI here too.
karim-en
approved these changes
Nov 14, 2023
mrLSD
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
near-plugins-derivewas the only workspace member that depended onborsh. However, it isn’t actually used. Insteadborshre-exported bynear-sdkis used, which is considered best practice. Removing theborshdependency might also prevent using it accidentally (instead ofborshre-exported bynear-sdk) in the future.