Success block called before dismissing web view.

[matheusbrat]

On fetchUserProfileWithIdToken:token the success block is called before dismissing the web view, if our success block needs to present some view controller it will not be able to present it, because the web view is on top of the view hierarchy causing an error.

We tried to execute [self dismiss] before calling the success block and it worked. Is there any reason to call the success block before dismissing the web view?

- (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction decisionHandler:(void (^)(WKNavigationActionPolicy))decisionHandler {
    A0LogVerbose(@"Loading URL %@", navigationAction.request.URL);
    NSURLRequest *request = navigationAction.request;
    NSURL *url = request.URL;
    BOOL isCallback = [self.authentication validateURL:url];
    if (!isCallback) {
        decisionHandler(WKNavigationActionPolicyAllow);
        return;
    }
    NSError *error;
    A0Token *token = [self.authentication tokenFromURL:url error:&error];
    if (token) {
        A0IdPAuthenticationBlock success = self.onAuthentication;
        @weakify(self);
        [self showProgressIndicator];
        [self.client fetchUserProfileWithIdToken:token.idToken success:^(A0UserProfile *profile) {
            @strongify(self);
            if (success) {
                success(profile, token);
            }

            decisionHandler(WKNavigationActionPolicyCancel);
            [self dismiss];
        } failure:^(NSError *error) {
            @strongify(self);
            [self handleError:error decisionHandler:decisionHandler];
        }];
    } else {
        [self handleError:error decisionHandler:decisionHandler];
    }
}

[hzalaz]

No reason at all, I have a similar issue with some type of errors that will show an alert so they are probably related. I am thinking of using dispatch_async in the main queue to enforce it and avoid switching them in code by accident in the future