OIDC Conformant toggle #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added flags for pipeline mode and audience Database/Enterprise Logins support new pipeline WebAuth added audience supportg
Legacy flag Tests updated
|
Only missing functionality at this point is confirmed MFA support, this has been provisioned into an Auth0.Swift PR based upon params being the same as legacy mode. Once confirmed in Auth0.Swift, can be added to this PR. |
hzalaz
suggested changes
Dec 30, 2016
| @@ -36,6 +36,7 @@ struct Auth0OAuth2Interactor: OAuth2Authenticatable { | |||
| .connection(connection) | |||
| .scope(self.options.scope) | |||
| .parameters(parameters) | |||
| .audience(self.options.audience ?? "") | |||
There was a problem hiding this comment.
This is yet another hack, we should not send audience if it's not specified
| parameters: self.options.parameters | ||
| ) | ||
| .start { self.handle(result: $0, callback: callback) } | ||
| if self.options.oidcConformant { |
There was a problem hiding this comment.
I saw this pattern a couple of times, wouldn't it better to just abstract this away?.
There was a problem hiding this comment.
Also since both methods return the same request we can just start it in one place
Fail for mfa in oidc mode
hzalaz
approved these changes
Dec 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.