-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC Conformant toggle #361
Conversation
Added flags for pipeline mode and audience Database/Enterprise Logins support new pipeline WebAuth added audience supportg
Legacy flag Tests updated
Only missing functionality at this point is confirmed MFA support, this has been provisioned into an Auth0.Swift PR based upon params being the same as legacy mode. Once confirmed in Auth0.Swift, can be added to this PR. |
@@ -36,6 +36,7 @@ struct Auth0OAuth2Interactor: OAuth2Authenticatable { | |||
.connection(connection) | |||
.scope(self.options.scope) | |||
.parameters(parameters) | |||
.audience(self.options.audience ?? "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is yet another hack, we should not send audience if it's not specified
parameters: self.options.parameters | ||
) | ||
.start { self.handle(result: $0, callback: callback) } | ||
if self.options.oidcConformant { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this pattern a couple of times, wouldn't it better to just abstract this away?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also since both methods return the same request we can just start it in one place
Fail for mfa in oidc mode
No description provided.