Disable log in after sign up #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hzalaz
suggested changes
Dec 30, 2016
| messageLabel.textAlignment = .center | ||
| messageLabel.font = regularSystemFont(size: 15) | ||
|
|
||
| switch(status) { |
There was a problem hiding this comment.
Why don't we have this logic in the status itself?
| import Foundation | ||
|
|
||
| enum NotificationStatus { | ||
| case signedup |
| if self.options.loginAfterSignup { | ||
| login.start { self.handle(result: $0, callback: { callback(nil, $0) }) } | ||
| } else { | ||
| callback(nil,.noLoginAfterSignup) |
There was a problem hiding this comment.
This is hardly an error and we should have a better to switch screens
Generic notification presenter added Tests added
hzalaz
force-pushed
the
feature_login_after_signup
branch
from
69d034e
to
edeeec6
Compare
OIDC vs Non-OIDC
Now instead of Results we have a different callback for event type: - auth - cancel - error - signup (wip) - forgotPassword (wip) They will work mostly as events, and some of them can be triggered in the same lock run, e.g. auth & signup.
Also renamed internal results to better reflect the action that triggered it.
hzalaz
force-pushed
the
feature_login_after_signup
branch
2 times, most recently
from
8914401
to
97aad7e
Compare
hzalaz
force-pushed
the
feature_login_after_signup
branch
from
97aad7e
to
78a214e
Compare
hzalaz
approved these changes
Jan 10, 2017
hzalaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic notification presenter added
Assets added
Tests added