Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch for custom oauth2 strategies #164

Closed
jlaxson opened this issue Aug 26, 2015 · 0 comments · Fixed by #171
Closed

Mismatch for custom oauth2 strategies #164

jlaxson opened this issue Aug 26, 2015 · 0 comments · Fixed by #171

Comments

@jlaxson
Copy link

jlaxson commented Aug 26, 2015

I have configured a custom oauth2 connection as described in https://auth0.com/docs/connections/social/oauth2.

Fixing the theme to show correctly in the provider list was easy-ish, however when trying to authenticate with this provider, Lock tries to use a connection name of "oauth2" (i.e. the strategy name) instead of the name of the custom connection. The issue seems to be centered on A0SocialLoginViewController:118:

[authenticator authenticateWithConnectionName:strategy.name parameters:self.parameters success:successBlock failure:failureBlock];

This seems inherently wrong because you're using the strategy name as a connection name when they should not depend at all on each other.

How should I handle this? It appears there would also be an issue with supporting multiple connections with the oauth2 strategy, as only one option would be presented to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant