-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State Handler with Custom Session Store #233
Comments
@datasage How is that possible? Looking into the constructor code: if (isset($config['state_handler'])) {
if ($config['state_handler'] === false) {
$this->stateHandler = new DummyStateHandler();
} else {
$this->stateHandler = $config['state_handler'];
}
} else {
$this->stateHandler = new SessionStateHandler(new SessionStore());
} when |
Currently the type hint on the session state handler class references
session store instead of the interface. So I have to duplicate it to use it.
|
@datasage - Good find, thank you! If you can put through a PR ( |
Adding in 5.1.1, PR coming now |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently the state handler will initialize a new session store when first created. Even if a custom session store is provided.
If a custom session store is used, it should be either able to be passed into the SessionStateHandler class or automatically used when instantiating the class.
SessionStateHandler could instead allow anything that implements StoreInterface, instead of just SessionStore.
The text was updated successfully, but these errors were encountered: