Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use form_post instead of fragment if supported by the provider #4

Closed
jfromaniello opened this issue Nov 22, 2018 · 3 comments · Fixed by #13
Closed

Use form_post instead of fragment if supported by the provider #4

jfromaniello opened this issue Nov 22, 2018 · 3 comments · Fixed by #13
Labels
enhancement New feature or request

Comments

@jfromaniello
Copy link
Member

We could use form_post instead of fragment for fragment response types IF the provider lists form_post as supported.
@jfromaniello jfromaniello added the enhancement New feature or request label Nov 22, 2018
@jfromaniello jfromaniello reopened this Nov 27, 2018
@joshcanhelp joshcanhelp mentioned this issue Sep 18, 2019
Merged
1 task
@joshcanhelp
Copy link
Contributor

See #13 for reasons to keep response_type=fragment around

@panva
Copy link
Contributor

panva commented Sep 26, 2019

@joshcanhelp the point here was to default to form_post when its supported, that is still something we should do. Please re-open.

@joshcanhelp
Copy link
Contributor

It already defaults to form_post:

https://github.com/auth0/express-openid-connect/blob/master/lib/config.js#L6-L10

App fails on first load if that's invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove fragment response type and repost view
3 participants
@jfromaniello @panva @joshcanhelp