api_identifier config is not passed to Auth0\SDK\Auth0 config as audience

[iSerter]

Problem

Auth0 Laravel package uses the api_identifier config key, which is the default JWT audience.
See https://github.com/auth0/laravel-auth0/blob/master/src/Auth0/Login/Auth0Service.php#L204
However, Auth0 PHP SDK -which is a dependency of this package- is using the audience config key to create a login URL.
So setting api_identifier in the config, does not add the audience param to the login URL.

Expected behavior?

I'd expect the login URL to include the audience I set in the config file.

Reproduction

Fresh install of the package and following the official docs will cause it.

Solution

It's possible to pass the audience as an additional parameter, and it'll work. However, what's the point of the config then?
I think something like this would make things much easier;
iSerter@011190a

Environment

PHP 8
Laravel 8
auth0/login: 6.4

[evansims]

Hey @iSerter! Good catch, thank you! Your solution looks reasonable, I'll be sure to update this in the next major to reflect the same naming as the upstream SDK. If you'd like, would you want to create a PR with that suggestion I can merge your fix? I can do it if you'd rather

[iSerter]

Hi @evansims,
Thank you for checking on the issue and responding. I have created a PR for the commit I had shared as an example in the issue description;

#214

[evansims]

Thanks very much for catching this and creating a fix, @iSerter! Really appreciate it. I'll ship this as a new bugfix release this coming week.

[Tamrael]

after pulling in 6.4.1 we run into "Service not found" with the a call like this

app('auth0')->login(null, null, ['scope' => 'openid profile email']);

resulting in the audience in the redirect being set to the client id of the app.
there is no way anymore to not set an audience for the login call to auth in 6.4.1 as far as I can tell.
"api_identifier" is mandatory because the jwt token decoding needs it. so the isset check is obsolete because the api_identifier will always be set.

maybe i'm doing something wrong?

reverting back to 6.4.0 fixes the issue but that's not a solution I want to keep forever

[evansims]

Hey @Tamrael, would you mind creating a separate issue detailing the issue you're hitting? I'm not sure I'm following entirely, but if you can break it down a bit more in that separate ticket we can work through it together. Thanks.

[Tamrael]

@evansims absolutely. opened #233 and added some more description to the problem we encountered