Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pls change config arg name #95

Closed
ekadesign opened this issue Mar 5, 2018 · 3 comments
Closed

pls change config arg name #95

ekadesign opened this issue Mar 5, 2018 · 3 comments
Milestone

Comments

@ekadesign
Copy link

ekadesign commented Mar 5, 2018

in the package, config name suported_algs is not valid, but in this repo config name is correct. Please change it on "supported algs".

vendor/auth0/login/src/config/config.php
<?php 
return array(
    /*
    |--------------------------------------------------------------------------
    |   Supported algs by your API
    |--------------------------------------------------------------------------
    |   Algs supported by your API
    |
    */
    // 'suported_algs'        => ['HS256'],
);
@joshcanhelp
Copy link
Contributor

@ekadesign - I'm a little confused. It's correct in the file you're referencing:

https://github.com/auth0/laravel-auth0/blob/master/src/config/config.php#L91

Is it incorrect somewhere else? This is an artifact from an old version of a JWT library we're using.

@ekadesign
Copy link
Author

@joshcanhelp in this repo all is ok. but if you using composer require in config file on vendor dir has this bug. And my codepast from package

@joshcanhelp joshcanhelp added this to the 5.1.0 milestone Mar 20, 2018
@joshcanhelp
Copy link
Contributor

Everything should be cleared up with 5.1.0, coming out in just a bit today.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants