Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close button is missing #1863

Closed
guosheng19 opened this issue May 12, 2020 · 3 comments · Fixed by #1872
Closed

close button is missing #1863

guosheng19 opened this issue May 12, 2020 · 3 comments · Fixed by #1872
Labels
bug This points to a verified bug in the code

Comments

@guosheng19
Copy link

I updated auth0-lock from version 11.17 to 11.24.0, then the close button on the top-right corner is gone.

@stevehobbsdev
Copy link
Contributor

stevehobbsdev commented May 12, 2020

Thanks for raising - this looks like it might be related to #1846.

Let me investigate.

@stevehobbsdev stevehobbsdev added the bug This points to a verified bug in the code label May 12, 2020
@griffinmartin
Copy link

griffinmartin commented May 21, 2020

I'm experiencing the same issue as well.
The remember-me appears to be broken too.
Downgrading to 11.23.0 resolved these issues for me.

@adamjmcgrath
Copy link
Contributor

then the close button on the top-right corner is gone.

The header is further down in the DOM than the close button and they have matching z-index values so the header is winning

https://github.com/auth0/lock/blob/master/css/index.styl#L178
https://github.com/auth0/lock/blob/master/css/index.styl#L204

close button z-index should be > header z-index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants