Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single AD connection without domain shows undefined in message #627

Closed
hzalaz opened this issue Sep 27, 2016 · 2 comments
Closed

Single AD connection without domain shows undefined in message #627

hzalaz opened this issue Sep 27, 2016 · 2 comments
Assignees
Labels
bug This points to a verified bug in the code
Milestone

Comments

@hzalaz
Copy link
Member

hzalaz commented Sep 27, 2016

When the client only allows a single AD connection, Lock will display the form for username/password with the title Please enter your coorporate credentials at {domain}. We need to avoid showing the undefined by changing the message or hiding for this specific case

@hzalaz hzalaz added P3: Important bug This points to a verified bug in the code labels Sep 27, 2016
@jasonhjohnson
Copy link

+1

@sykesjd
Copy link

sykesjd commented Jan 18, 2024

The fix in the linked PR does not actually fully fix the issue - it only checks for null domain and not undefined domain, so the issue as originally described still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

4 participants