Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages do not allow html formatting #878

Closed
dariobanfi opened this issue Feb 23, 2017 · 1 comment · Fixed by #928
Closed

Error messages do not allow html formatting #878

dariobanfi opened this issue Feb 23, 2017 · 1 comment · Fixed by #928
Assignees
Labels
bug This points to a verified bug in the code

Comments

@dariobanfi
Copy link
Contributor

Hi,

Is there any reason why error messages displayed by the lock do not allow html formatting?

For example, given this lock parameters:

error: {
  login: {
     'lock.invalid_email_password': '<b>Error</b>, Invalid Email or Password'
  }
}

Which results as:

screen shot 2017-02-23 at 17 06 25

This could be easily changed by using i18n.html here: https://github.com/auth0/lock/blob/master/src/core/index.js#L511 and it's what most of other messages do (for example success.signUp).

@luisrudge
Copy link
Contributor

Thanks @dariobanfi. I added a PR to support html messages (both error and success). We'll discuss internally if we want to support more stuff as html or not, but this should be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants