Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.12.2 will not npm install with node 7.6 #901

Closed
mcrawshaw opened this issue Mar 4, 2017 · 10 comments
Closed

10.12.2 will not npm install with node 7.6 #901

mcrawshaw opened this issue Mar 4, 2017 · 10 comments

Comments

@mcrawshaw
Copy link

error auth0-lock@10.12.2: The engine "node" is incompatible with this module. Expected version "~6.9.1".

I can see an update to package.json that may have already fixed. Would it be possible to release a new version?

Mark.

@fbascheper
Copy link

fbascheper commented Mar 6, 2017

Shouldn't package.json be updated to

"engines": {
    "node": ">= 6.9.1"
 },

to support node v7, instead of just

"node": "^6.9.1"

@hzalaz
Copy link
Member

hzalaz commented Mar 7, 2017

@fbascheper we only properly tested it with node 6 so We'd like to avoid unforeseen issues of using a new node major. We can update it once it's properly tested

@hzalaz
Copy link
Member

hzalaz commented Mar 7, 2017

@mcrawshaw it will be in next week release

@fbascheper
Copy link

OK, so you're supporting lock as a server-side application on node then?

Using it like that has never come to my mind. My issue is that yarn no longer allows a dependency for my angular2 projects (client side only), because I have node7 installed on my dev machine. This means I'm now stuck to using old auth-lock versions, or revert to node6 locally. Yuck.

@luisrudge
Copy link
Contributor

@fbascheper we're not supporting lock on node, but we need to make sure that you can clone this repo and you can build and test everything. This was only tested with node 6. I'll run some tests with node@7 and see if we can include that in the next release as well.

@fbascheper
Copy link

That would be awesome!

@evansiroky
Copy link

This issue is causing a lot of our continuous integration builds to fail at @conveyal. Would appreciate a release earlier than next week.

@evansiroky
Copy link

btw, we are using node 6, but Travis seems to use 6.10.0 by default which is not compatible with ~6.9.1.

@noah79
Copy link

noah79 commented May 24, 2017

This is starting to bite us. We only use auth0-lock in our client, but now our universal app is unable to build without downgrading node. Not good.

@luisrudge
Copy link
Contributor

@noah79 did you upgrade your lock version? We fixed this in #909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants