Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability caused by jws@3.1.4 #465

Closed
p-brighenti opened this issue May 16, 2018 · 4 comments · Fixed by #477
Closed

Security vulnerability caused by jws@3.1.4 #465

p-brighenti opened this issue May 16, 2018 · 4 comments · Fixed by #477

Comments

@p-brighenti
Copy link

In our project, Snyk reported jws@3.1.4 as a dependency with a known security vulnerability, because it depends on jwa@1.1.5.

The latest version of jws (3.1.5), no longer depends on the vulnerable dependency of base64url@2.0.0.

More info about the high severity vulnerability in jws@3.1.4 can be found at https://snyk.io/vuln/npm:base64url:20180511

@kyrylkov
Copy link

@ziluvatar FYA

A simple deps update should not take 6 days

@ziluvatar
Copy link
Contributor

@kyrylkov the upgrade is already in this PR: #466

Keep in mind our package.json definition allows JWS patch upgrades, you should be able to get the new JWS release right away.

I want to take a look to the fix from JWS first, I took a fast look yesterday and I'm not sure if the decoding works fine, but I want to do some checks before setting that version as default here, anyway, as I said, you could get it.

@kyrylkov
Copy link

kyrylkov commented May 22, 2018

Keep in mind our package.json definition allows JWS patch upgrades, you should be able to get the new JWS release right away.

You are correct. Somehow a few days ago (after jws 3.1.5 was released), full re-installation of jsonwebtoken still pulled 3.1.4, but not anymore. Probably package-lock.json was not deleted before re-installation.

@ziluvatar
Copy link
Contributor

v8.2.2 released with this fixed. Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants