Added Istanbul to check test-coverage #468
Conversation
|
Build has failed because of node 5's limitations with block scoped items... :-( My recommendation is to remove node <5 from the travis-testing-set and add the latest versions of node to the travis.yml... https://github.com/nodejs/Release#release-schedule indicates that 5 went out of life on 2016-06-30 |
|
I'll leave this on hold until we remove support for node 4 and 5. (I left a comment in your other PR #470) |
|
Because of the update of the CI, this can now be merged :-) (It is only a dev-dependency anyway) |
.gitignore
Outdated
| .nyc_output | ||
| coverage | ||
| node_modules_bak |
There was a problem hiding this comment.
Should this line be here? Seems like it might have been included accidentally.
There was a problem hiding this comment.
Ah, yes, because the cost-of-modules takes quite some time i cancelled it and it left this folder. I added it in the ignore as i figured this shouldn't be checked in. I will remove it from the gitignore ;-)
…dules and isn't needed in the ignore.
While looking to add tests for PR 413 i noticed it would be helpful to have an overview of the tested code. Hopefully this helps :)