Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests related to audience and aud #503

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

MitMaro
Copy link
Contributor

@MitMaro MitMaro commented Jul 9, 2018

Third PR for #492

This change extracts all tests in the existing test files related to audience and aud into a single test file. Several other tests are also added that were missing from the existing files.

I should have removed all references to audience and aud from the current test files.

I did not add a full suite of tests for the validation on providing aud in the payload as there does not seem to be any validation. There is also limited tests for providing an array for audience, as there is no additional validation on the array items. Both these issues could be handled with the next major release.

As always, suggestions or missing tests are more than welcome!

Coverage Master

=============================== Coverage summary ===============================
Statements   : 97.45% ( 229/235 )
Branches     : 97.06% ( 198/204 )
Functions    : 100% ( 23/23 )
Lines        : 97.84% ( 227/232 )
================================================================================

Coverage Branch

=============================== Coverage summary ===============================
Statements   : 97.87% ( 230/235 )
Branches     : 97.55% ( 199/204 )
Functions    : 100% ( 23/23 )
Lines        : 98.28% ( 228/232 )
================================================================================

This change extracts all tests in the existing test files related to
audience and aud into a single test file. Several other tests are also
added that were missing from the existing files.
@ziluvatar
Copy link
Contributor

Nice, I'll merge it. What do you mean by:

I should have removed all references to audience and aud from the current test files.

I downloaded your branch and all references in tests are only your new file.

@MitMaro
Copy link
Contributor Author

MitMaro commented Jul 12, 2018

The "should" was because I couldn't find any references with some simple searching of the existing tests. A more accurate statement would have been:

I removed all references to "audience" and "aud" from the existing test files that I could find.

@ziluvatar ziluvatar merged commit 53d405e into auth0:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants