Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Node version in Engines spec in package.json #528

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

aakash2602
Copy link
Contributor

Updated Node version from 0.12 to 1.4 in package.json Engines Spec

Fixes Issue #509

Updated Node version from 0.12 to 1.4 in package.json engines
@ziluvatar
Copy link
Contributor

I was going to check if the package is still compatible with that old version, however, I think it is better to state in the package json the versions we actually care about (we have CI set on them), so that would be >=4 for now. Do you want to update it?

@aakash2602
Copy link
Contributor Author

where do you want me to update that in package json?

@MitMaro
Copy link
Contributor

MitMaro commented Oct 16, 2018

I think @ziluvatar was saying to set the node version to >=4:

"node": ">=4"

@aakash2602
Copy link
Contributor Author

Ok will do that now

Updated Node version from 0.12 to 4 in package.json Engines Spec

Fixes Issue auth0#509
Copy link
Contributor

@MitMaro MitMaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the npm docs:

Unless the user has set the engine-strict config flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.

So even if this does show a warning for some users, it shouldn't be too big of an issue.

@ziluvatar
Copy link
Contributor

Thanks MitMaro, I was wondering what kind of release this should be, I think it will be in the next patch one, because, in the project we were really treating node 4 as the minimum node version, this is a fix just for the package.json (we could have broken compatibility with older than v4 at any moment, since it would have been fine to us).

@ziluvatar ziluvatar merged commit cfd1079 into auth0:master Oct 22, 2018
@aakash2602 aakash2602 deleted the patch-1 branch October 22, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants