Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement async/sync tests for sub claim #534

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Implement async/sync tests for sub claim #534

merged 1 commit into from
Oct 16, 2018

Conversation

MitMaro
Copy link
Contributor

@MitMaro MitMaro commented Oct 15, 2018

For #492

This implements the test helpers introduced in #523 for the sub claim. It's a pretty simple refactoring without any significant changes to the current tests.

Coverage Master

=============================== Coverage summary ===============================
Statements   : 97.87% ( 230/235 )
Branches     : 97.55% ( 199/204 )
Functions    : 100% ( 23/23 )
Lines        : 98.28% ( 228/232 )
================================================================================

Coverage Branch

=============================== Coverage summary ===============================
Statements   : 97.87% ( 230/235 )
Branches     : 97.55% ( 199/204 )
Functions    : 100% ( 23/23 )
Lines        : 98.28% ( 228/232 )
================================================================================

@MitMaro
Implement async/sync tests for sub claim
8cd3f39 
Refactor existing tests for the sub claim to use the async/sync test
helpers.
@ziluvatar ziluvatar merged commit 342b07b into auth0:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MitMaro @ziluvatar