Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running processes - The sort order for Started is a mess #1387

Closed
Sopor opened this issue Jul 30, 2019 · 5 comments
Closed

Running processes - The sort order for Started is a mess #1387

Sopor opened this issue Jul 30, 2019 · 5 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Jul 30, 2019

When i sort by Started the sort order will be a mess because it will sort by 0-9 and 07 is before 2018. Could this be fixed?

image

I also wondering if it could show a more specific Started time? I believe this will fix the above sort order issue if it show full date-month-day?

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2019

The sorting results are correct in terms of sorting but it sorts different kind of data, and I am not sure how it's related to the presentation (theme).

@jcameron Can we make proc module use make_date sub to generate time/date? By doing so, it will do sorting based on timestamp (delivered by theme_make_date), and thus will make it correct?

@iliajie iliajie closed this as completed Jul 30, 2019
@Sopor
Copy link
Contributor Author

Sopor commented Jul 31, 2019

So sort by Started is totally useless when it mixes time, dates and years like it was random. Is that really how it should work?

@iliajie
Copy link
Collaborator

iliajie commented Jul 31, 2019

This should be fixed on the server-side.

webmin pushed a commit to webmin/webmin that referenced this issue Jul 31, 2019
@jcameron
Copy link
Collaborator

I've checked in a fix to use proper date formatting for this field.

@iliajie
Copy link
Collaborator

iliajie commented Jul 31, 2019

Okay, cool.

I have made few tweaks as well and now sorting for Started not only works perfectly but also displays time in from now format, making it very comfortable to read.

Example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants