Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open URL from SDK should use the domain got from server #248

Closed
Tracked by #3431
fungc-io opened this issue Jul 13, 2023 · 3 comments
Closed
Tracked by #3431

open URL from SDK should use the domain got from server #248

fungc-io opened this issue Jul 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@fungc-io
Copy link
Member

fungc-io commented Jul 13, 2023

After applying custom domain
The authentication flow still work without changing the endpoint,
because it uses the domain retrieve from the server.

However the open settings page method is still using the endpoint.
It will be great if it use the custom domain automatically, so it is not necessary for the user to update the app.

@fungc-io fungc-io added the enhancement New feature or request label Jul 13, 2023
@joyzoursky
Copy link

joyzoursky commented Sep 21, 2023

Experiencing this issue when testing on version update for an exisitng app.

I think this is a should-fix bug more than enhancement issue, as it is quite often that end-user will not always keep their apps updated, then on old version they will see the invalid redirect URI error from authgear.

@fungc-io
Copy link
Member Author

tested, all is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants