No state in response when doing readSigninResponseState

[jamalavedra]

Hi,

when doing a silent signing, the callback always expects that there is a custom state url_state. This is required because:
SigninResponse.ts:

const splitState = decodeURIComponent(this.state).split(URL_STATE_DELIMITER);
this.state = splitState[0];

And then at the callback it throws readSigninResponseState: Error: No state in response from the readSigninResponseState function from OidcClient.ts.
This happens because when url_state is provided:

SigninRequest.ts

        if (url_state) {
            stateParam = `${stateParam}${URL_STATE_DELIMITER}${url_state}`;
        }

but url_state is optional.

[pamapa]

I do not understand what you mean:

SigninResponse.ts is protected by a if (this.state):

oidc-client-ts/src/SigninResponse.ts

Lines 55 to 61 in 3d403d9

	if (this.state) {
	const splitState = decodeURIComponent(this.state).split(URL_STATE_DELIMITER);
	this.state = splitState[0];
	if (splitState.length > 1) {
	this.url_state = splitState.slice(1).join(URL_STATE_DELIMITER);
	}
	}

SigninRequest.ts is protected by a if if (url_state):

oidc-client-ts/src/SigninRequest.ts

Lines 133 to 135 in 3d403d9

	if (url_state) {
	stateParam = `${stateParam}${URL_STATE_DELIMITER}${url_state}`;
	}

[jamalavedra]

but when if (this.state) is true, then at

oidc-client-ts/src/OidcClient.ts

Line 159 in 3d403d9

if (!response.state) {

it will throw an error of No state in response.
The state is indeed present because its properly prepared when creating the siginRequest, but if im not using a the url_state then the this.state = splitState[0] will be undefined which will make the condition above throw.

[pamapa]

it will throw an error of No state in response.
The state is indeed present because its properly prepared when creating the siginRequest, but if i'm not using a the url_state then the this.state = splitState[0] will be undefined which will make the condition above throw.

url_state is optional. You always have a state. This state is required to match the original request. See

oidc-client-ts/src/SigninRequest.ts

Lines 155 to 158 in 1d39fe7

	return new SigninRequest({
	url: parsedUrl.href,
	state,
	});