Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect_uri can not be overridden #468

Closed
keropodium opened this issue Apr 6, 2022 · 3 comments · Fixed by #471
Closed

redirect_uri can not be overridden #468

keropodium opened this issue Apr 6, 2022 · 3 comments · Fixed by #471
Labels
enhancement New feature or request
Milestone

Comments

@keropodium
Copy link

keropodium commented Apr 6, 2022

Following the same fashion as: #436

I think we are missing the redirect_uri property in type ExtraSigninRequestArgs at src/UserManager.ts

@pamapa
Copy link
Member

pamapa commented Apr 6, 2022

We can do so. What is your use-case? Why do you need it?

@pamapa pamapa added the enhancement New feature or request label Apr 6, 2022
@keropodium
Copy link
Author

We can do so. What is your use-case? Why do you need it?

We are just migrating from old oidc-client.
Current implementation lets our user click on the login button from every page after any in-browser route change, so we are calling userManager.signinRedirect() on user demand and returning to the same url after login.

@pamapa
Copy link
Member

pamapa commented Apr 6, 2022

Feel free to provide a MR for that...

@pamapa pamapa added this to the 2.0.4 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants