Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate unifying requestID and OTel traceID #1789

Open
vroldanbet opened this issue Mar 12, 2024 · 1 comment
Open

Investigate unifying requestID and OTel traceID #1789

vroldanbet opened this issue Mar 12, 2024 · 1 comment
Labels
area/observability Affects telemetry data

Comments

@vroldanbet
Copy link
Contributor

Follow up to #1772

SpiceDB now logs OTels traceID, along the requestID field users can inject via HTTP headers. We should explore if there is a way to unify those.
@vroldanbet vroldanbet added the area/observability Affects telemetry data label Mar 12, 2024
@vroldanbet vroldanbet mentioned this issue Mar 12, 2024
Merged
@vroldanbet
Copy link
Contributor Author

We recently moved to https://github.com/rs/xid to replace our bespoke requestID generator. XID is 12 bytes.
The OTel spec indicates 16 bytes for a traceID, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/observability Affects telemetry data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vroldanbet