Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete uploaded files when you delete an import job #104

Closed
tinmarr opened this issue Jul 14, 2023 · 3 comments · Fixed by #108
Closed

Delete uploaded files when you delete an import job #104

tinmarr opened this issue Jul 14, 2023 · 3 comments · Fixed by #108
Assignees
@Jaspreet-singh-1032

Comments

@tinmarr
Copy link

tinmarr commented Jul 14, 2023

Would be good to delete the uploaded files once the job is deleted. Currently, this needs to be done manually (or automatically every x days using another celery task).
@timthelion
Copy link
Member

Wait, once the job is run or the job is deleted?

@tinmarr
Copy link
Author

tinmarr commented Jul 15, 2023

Once it is deleted

@timthelion
Copy link
Member

https://stackoverflow.com/questions/16041232/django-delete-filefield#16041527

We can probably add a post_delete safely here. I've got nothing against a PR that does so...

@Jaspreet-singh-1032 Jaspreet-singh-1032 self-assigned this Jul 23, 2023
@Jaspreet-singh-1032 Jaspreet-singh-1032 mentioned this issue Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaspreet-singh-1032 Jaspreet-singh-1032

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delete uploaded file on import job delete Jaspreet-singh-1032/django-import-export-celery
3 participants
@timthelion @tinmarr @Jaspreet-singh-1032