Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update project setup to make collaboration easier #40

Closed
Goldziher opened this issue May 19, 2021 · 8 comments
Closed

update project setup to make collaboration easier #40

Goldziher opened this issue May 19, 2021 · 8 comments

Comments

@Goldziher
Copy link

Hi There,

So i forked this repo to make some updates and I encountered some difficulties with the setup- I would like to suggest the following updates:

  1. migrate to using poetry instead of setup.py, and then add the dependencies and dev dependencies at the root level.
  2. migrate to using github actions, works with poetry: https://github.com/snok/install-poetry
  3. add pre-commit
  4. add contribution guidelines
  5. add unit tests - currently there is really nothing

I would be glad to help with some of these if you are interested.

@timthelion
Copy link
Member

Would 1 maybe fix #20 ?

@timthelion
Copy link
Member

What would be in 3?

@timthelion
Copy link
Member

5 the only "test" is this

class AdminSmokeTest(tests.AdminSiteSmokeTest):

@timthelion
Copy link
Member

What would 2 do?

@timthelion
Copy link
Member

You did see that we have travis https://travis-ci.com/github/auto-mat/django-import-export-celery/jobs/506689595 didn't you?

@Goldziher
Copy link
Author

So,

1.poetry is very nice and simple to use.
2. See this for pre-commit: https://link.medium.com/HVz8neQ5pgb
3. Travis changed their policies, and github actions are great.
4. Zero coverage

@timthelion
Copy link
Member

How did travis change their policies?

@Goldziher
Copy link
Author

Well, they changed their policy regard open source etc. Google it.

Anyhow, I ended up writing custom logic instead of using this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants