Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we maybe drop the Python 3.9 support? #99

Closed
QuantumChemist opened this issue Aug 27, 2024 · 6 comments · Fixed by #168
Closed

Should we maybe drop the Python 3.9 support? #99

QuantumChemist opened this issue Aug 27, 2024 · 6 comments · Fixed by #168

Comments

@QuantumChemist
Copy link
Collaborator

I'm just wondering if we should drop the Python 3.9 because the most recent numpy versions won't support it anymore?

@JaGeo
Copy link
Collaborator

JaGeo commented Aug 27, 2024

I would simply follow atomate2 in this regard. 😃

Was it dropped already?

@QuantumChemist
Copy link
Collaborator Author

I would simply follow atomate2 in this regard. 😃

Was it dropped already?

It was dropped in pymatgen only so far. I haven't seen it in atomate2 so far.

@JaGeo
Copy link
Collaborator

JaGeo commented Aug 27, 2024

We can drop it if pymatgen has dropped it. Is it merged yet?

@QuantumChemist
Copy link
Collaborator Author

We can drop it if pymatgen has dropped it. Is it merged yet?

Yes, it is merged materialsproject/pymatgen#4009

@JaGeo
Copy link
Collaborator

JaGeo commented Aug 27, 2024

Then, I think we could drop it.
Just to make sure: @YuanbinLiu , which Python version are you using? Is it okay to drop Python 3.9 support? Thank you!

@naik-aakash
Copy link
Collaborator

Partially addressed already in #112 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants