Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate start_at date during assessment import if other dates absent #1927

Closed
damianhxy opened this issue Jun 16, 2023 · 0 comments · Fixed by #1932
Closed

Propagate start_at date during assessment import if other dates absent #1927

damianhxy opened this issue Jun 16, 2023 · 0 comments · Fixed by #1932

Comments

@damianhxy
Copy link
Member

damianhxy commented Jun 16, 2023

Your environment
master (5e33614)

Steps To Reproduce
Import an assessment whose .yml file only defines the start_at field.

Current behavior
All fields (due_at, start_at, end_at, visible_at, grading_deadline) are set to the current date + 1 day.

Expected behavior
All fields should take on the value of the start_at field.

Notes
This is to make it more convenient to create a non-submittable assessment (used by 15-122). The relevant logic lies in assessment.rb#deserialize.

Also note that visible_at is an unused field and ought to be removed.

@damianhxy damianhxy self-assigned this Jun 16, 2023
@damianhxy damianhxy changed the title Propagate start_at date during asmt import if other dates absent Propagate start_at date during assessment import if other dates absent Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant