Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test for query with multiple indexes #344

Merged
merged 7 commits into from
Sep 25, 2018
Merged

Adding test for query with multiple indexes #344

merged 7 commits into from
Sep 25, 2018

Conversation

fishcharlie
Copy link
Member

@fishcharlie fishcharlie commented Apr 20, 2018 •
edited
Loading

This PR closes #343

@fishcharlie fishcharlie mentioned this pull request Apr 20, 2018
Closed
@coveralls
Copy link

coveralls commented Apr 23, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 81.852% when pulling 3a85c95 on fishcharlie:queryMultipleIndexes into 388662c on automategreen:master.

@fishcharlie fishcharlie added this to the v0.9.0 milestone Apr 23, 2018
@ricxsar
Copy link

ricxsar commented Apr 24, 2018

I also confirm that this PR solves the issue #343

@fishcharlie fishcharlie modified the milestones: v0.9.0, v1.0 Jun 13, 2018
@fishcharlie fishcharlie mentioned this pull request Sep 25, 2018
Merged
@fishcharlie fishcharlie merged commit 5be0d18 into dynamoose:master Sep 25, 2018
@fishcharlie fishcharlie deleted the queryMultipleIndexes branch September 25, 2018 20:55
@coveralls
Copy link

coveralls commented Sep 25, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 651

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 107 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.5%) to 84.641%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Query.js 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
lib/Schema.js 4 91.12%
lib/Attribute.js 5 86.52%
lib/Query.js 6 85.35%
lib/Scan.js 21 84.11%
lib/Table.js 22 77.93%
lib/Model.js 49 83.56%
Totals Coverage Status
Change from base Build 609: 0.5%
Covered Lines: 1845
Relevant Lines: 2106
💛 - Coveralls

@fishcharlie fishcharlie mentioned this pull request Oct 14, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandongoode brandongoode Awaiting requested review from brandongoode

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table index not selected correctly when querying
4 participants
@fishcharlie @coveralls @ricxsar @yokkoyokko