Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve recognizability of inline code elements #2739

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Mar 10, 2021

Fix

Fixes #1891. Increase recognizability of inline code elements in Markdown
previews by applying a subtle background color to them.

Before After After (Dark)
before after after-dark

Test

  1. Create a new note.
  2. Click note Info button in the top-right.
  3. Enable Markdown formatting.
  4. Add an inline code block to the note content.
  5. Click Preview button in the top-right.

Expected Outcome: The inline code element is styled with a monospace typeface
and a background color different than rest of the content.

Release

Improve recognizability of inline code elements.

Increase recognizability of inline code elements in Markdown previews by
applying a subtle background color to them.
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, works well and makes it much nicer to read inline code.

@dcalhoun dcalhoun merged commit 6039b85 into develop Mar 11, 2021
@dcalhoun dcalhoun deleted the update/style-inline-code branch March 11, 2021 15:00
@sandymcfadden sandymcfadden added this to the 2.9.0 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code elements are hard to distinguish
2 participants