Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sort options bar and update display settings #2841

Merged
merged 6 commits into from
Apr 16, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #2769

This removes the sort options bar from the note list and updates the sort options in the Display Settings to match the options which the sort bar offered.

Screenshots

Before Screen Shot 2021-04-13 at 8 40 34 AM Screen Shot 2021-04-13 at 8 41 07 AM
After Screen Shot 2021-04-13 at 8 41 47 AM Screen Shot 2021-04-13 at 8 42 14 AM

Test

  1. Ensure sort options do not show in the note list.
  2. Go to display settings.
  3. Ensure the sort options show completely.
  4. Ensure the sort options sort appropriately.

Release

  • Removed the sort options bar from the note list and updated the sort options in the Settings.

@sandymcfadden sandymcfadden added this to the 2.10.0 milestone Apr 13, 2021
@sandymcfadden sandymcfadden requested a review from fluiddot April 13, 2021 11:45
@sandymcfadden sandymcfadden self-assigned this Apr 13, 2021
@sandymcfadden sandymcfadden marked this pull request as ready for review April 13, 2021 12:51
@SylvesterWilmott
Copy link
Contributor

Thanks @sandymcfadden

Looks good! Can we just change "Alphabetically" to "Name" so that the first two sorting options are "Name: A-Z" and "Name Z-A".

@sandymcfadden
Copy link
Contributor Author

Thanks @SylvesterWilmott

Looks good! Can we just change "Alphabetically" to "Name" so that the first two sorting options are "Name: A-Z" and "Name Z-A".

I have that updated now.

Copy link
Contributor

@SylvesterWilmott SylvesterWilmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandymcfadden sandymcfadden requested a review from a team April 14, 2021 19:23
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. The code looks fine. RIP this component that I personally liked and worked hard on. You were a good component, sort order selector. I'm sorry your time with us was so short.

@sandymcfadden sandymcfadden merged commit df4921f into develop Apr 16, 2021
@sandymcfadden sandymcfadden deleted the update/move-sort-order-options branch April 16, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Sorting Options to Settings
3 participants