-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sort options bar and update display settings #2841
Conversation
Thanks @sandymcfadden Looks good! Can we just change "Alphabetically" to "Name" so that the first two sorting options are "Name: A-Z" and "Name Z-A". |
Thanks @SylvesterWilmott
I have that updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sandymcfadden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected. The code looks fine. RIP this component that I personally liked and worked hard on. You were a good component, sort order selector. I'm sorry your time with us was so short.
Fix
Fixes #2769
This removes the sort options bar from the note list and updates the sort options in the Display Settings to match the options which the sort bar offered.
Screenshots
Before
After
Test
Release