Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search global #2878

Merged
merged 3 commits into from
May 1, 2021
Merged

Make search global #2878

merged 3 commits into from
May 1, 2021

Conversation

sandymcfadden
Copy link
Contributor

@sandymcfadden sandymcfadden commented Apr 28, 2021 •
edited
Loading

Fix

Fixes #2626
This updates the way search is handled if there is an opened tag to match the other platforms.
Currently, if there is a tag selected the search is restricted to that tag.
This updates so that whenever a search is placed it is for all notes. Searches can still be restricted to tags using the syntax tag:recipe in the search field.

Before Screen Shot 2021-04-28 at 2 28 03 PM Screen Shot 2021-04-28 at 2 27 51 PM Screen Shot 2021-04-28 at 2 27 35 PM Screen Shot 2021-04-28 at 2 27 26 PM Screen Shot 2021-04-28 at 2 26 57 PM
After Screen Shot 2021-04-28 at 2 31 23 PM Screen Shot 2021-04-28 at 2 31 04 PM Screen Shot 2021-04-28 at 2 30 32 PM Screen Shot 2021-04-28 at 2 30 10 PM Screen Shot 2021-04-28 at 2 29 55 PM

Test

  1. Select a tag
  2. Ensure only notes with that tag are displayed
  3. Perform a search
  4. Ensure any note matching shows

Release

  • Updated search so that all notes are searched even if there is a currently selected tag.

@sandymcfadden sandymcfadden self-assigned this Apr 28, 2021
@sandymcfadden sandymcfadden force-pushed the update/make-search-global branch from 30f9017 to 6e49791 Compare April 28, 2021 17:17
@sandymcfadden sandymcfadden requested a review from a team April 28, 2021 17:35
@sandymcfadden sandymcfadden added this to the 2.11.0 milestone Apr 28, 2021
@sandymcfadden sandymcfadden marked this pull request as ready for review April 28, 2021 17:36
codebykat
codebykat approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works fine. I wonder if this is going to be confusing.

@sandymcfadden
Copy link
Contributor Author

Looks good, works fine. I wonder if this is going to be confusing.

I think it will take some getting used to, but after playing with it for a while and seeing how it works on other platforms, I think this makes sense.

@sandymcfadden sandymcfadden merged commit ec8b3aa into develop May 1, 2021
@sandymcfadden sandymcfadden deleted the update/make-search-global branch May 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebykat codebykat codebykat approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

Search should be global
2 participants
@sandymcfadden @codebykat