Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to search for tag:untagged to find all untagged notes #2879

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Add ability to search for tag:untagged to find all untagged notes #2879

merged 3 commits into from
Apr 30, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #1644

This adds the ability to use the tag search syntax to find all notes without any tags. You can now search with tag:untagged.

Screen Capture on 2021-04-29 at 08-58-33

Test

  1. Ensure you have some notes with no tags.
  2. Search for tag:untagged.
  3. Notice all untagged notes show in the note list.

Release

  • Added the option to search with tag:untagged to find notes without any tags.

@sandymcfadden sandymcfadden added this to the 2.11.0 milestone Apr 29, 2021
@sandymcfadden sandymcfadden requested a review from a team April 29, 2021 12:03
@sandymcfadden sandymcfadden self-assigned this Apr 29, 2021
belcherj
belcherj approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Should we include untagged in the list of tag suggestions?

@sandymcfadden
Copy link
Contributor Author

This is great. Should we include untagged in the list of tag suggestions?

Good call. I've added that now!

@sandymcfadden sandymcfadden requested review from belcherj and a team April 29, 2021 22:26
belcherj
belcherj approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I think having the untagged being added in the component is better than doing it deeper in the system.

@sandymcfadden sandymcfadden merged commit 019e6ac into develop Apr 30, 2021
@sandymcfadden sandymcfadden deleted the add/search-untagged-notes branch April 30, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

Search: Allow searching for untagged notes with tag: syntax
2 participants
@sandymcfadden @belcherj