Continue adding light mode custom color variables #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandymcfadden
changed the base branch from
develop
to
update/move-to-custom-css-properties
Update most uses of -white to use --primary-color in light mode Update uses of -gray-50, 40, 60 to --secondary-color in light mode Update uses of -gray-80 to be --tertiary-color Update uses of -simplenote-blue-50 to be --accent-color Update uses of white and hex value to be --primary-color in light mode Update uses of -simplenote-blue-5 to be --highlight-color in light mode Following a WordPress example renaming new css variables. Starting with --primary-color to --background-color Following a WordPress example renaming new css variables. --secondary-color to --foreground-color Following a WordPress example renaming new css variables. --tertiary-color to --primary-color Update uses of -gray-5 to be --secondary-color in light mode Update uses of -gray-20 to be --tertiary-color in light mode Update overlay colors to use --overlay-color in light mode Fix a couple of small CSS lint errors.
sandymcfadden
force-pushed
the
update/additional-light-mode-custom-color-variables
branch
from
c5c04c9 to
5225cbf
Compare
sandymcfadden
deleted the
update/additional-light-mode-custom-color-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This continues on with the work in #2874
It adds more color variables for light mode. Those colors are then updated throughout the app to use the variables instead.
Test
Release
NA