Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the results bar bar text from always being plural #2892

Merged
merged 1 commit into from
May 4, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #2887

Currently, if there is only one search result the search results bar at the bottom says "1 Results" instead of "1 Result".

This checks and displays the plural version only if there is more than one search result.

Before:
Screen Shot 2021-05-04 at 8 20 48 AM

After:
Screen Shot 2021-05-04 at 8 19 27 AM

Test

  1. Have a note that contains a keyword only once
  2. Search for this keyword
  3. Select this note
  4. Ensure the search results bar at the bottom says "1 Result"
  5. Search for a keyword with more than one result
  6. Ensure the search results bar at the bottom says "Results" in plural now.

Release

  • Fixed search results bar to only use the plural Results if there is more than one matching keyword.

@sandymcfadden sandymcfadden added this to the 2.12.0 milestone May 4, 2021
@sandymcfadden sandymcfadden requested a review from a team May 4, 2021 11:21
@sandymcfadden sandymcfadden self-assigned this May 4, 2021
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sandymcfadden sandymcfadden merged commit 0c21526 into develop May 4, 2021
@sandymcfadden sandymcfadden deleted the fix/search-results-bar-text branch May 4, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 Results note search summary
2 participants