Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade electron dependancies #2895

Merged
merged 2 commits into from
May 28, 2021
Merged

Upgrade electron dependancies #2895

merged 2 commits into from
May 28, 2021

Conversation

sandymcfadden
Copy link
Contributor

@sandymcfadden sandymcfadden commented May 4, 2021 •
edited
Loading

Fix

Resolves #2886
Resolves #2905

This upgrades the Electron and Electron Builder dependencies.

The updates introduced three issues:

  • Logging out wouldn't refresh to the login screen.
  • Linux build wouldn't render properly, only had a white screen.
  • New files were created in the build process which were persisting and breaking the process.

All of these have fixed here as well.

Test

All Electron builds will need in-depth testing. We can follow the testing checklist through.

Release

  • Upgraded the Electron and Electron Builder dependencies

@sandymcfadden sandymcfadden added this to the 2.12.0 milestone May 4, 2021
@sandymcfadden sandymcfadden self-assigned this May 4, 2021
@sandymcfadden sandymcfadden marked this pull request as ready for review May 4, 2021 16:48
@sandymcfadden sandymcfadden modified the milestones: 2.12.0, 2.13.0 May 15, 2021
@sandymcfadden sandymcfadden force-pushed the chore/upgrade-electron-dependancies branch from 7967e6b to 9ac76ee Compare May 24, 2021 11:50
@pachlava
Copy link
Contributor

pachlava commented May 24, 2021 •
edited
Loading

I did a humble amount of exploratory testing (overall 1-2 hours of using the app), and found no issues at all. Tested under Windows and macOS. The PR solves the issue described in #2886

@codebykat codebykat self-requested a review May 27, 2021 23:37
codebykat
codebykat approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I smoke-tested the app including keyboard shortcuts, internal and external links, and dark theme, didn't find any regressions.

@sandymcfadden sandymcfadden merged commit 104e2a4 into develop May 28, 2021
@sandymcfadden sandymcfadden deleted the chore/upgrade-electron-dependancies branch May 28, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebykat codebykat codebykat approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Wayland support [macOS] Window top corners look both rounded and sharp under dark theme
3 participants
@sandymcfadden @pachlava @codebykat