Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search scrollbar highlights #2910

Merged
merged 1 commit into from
May 28, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #2903

After a previous fix with the search highlighting, I broke the search scrollbar highlights showing where in the note search matches were when traversing through search results.

This fixes that issue by ensuring it appears even when going through search results.

Before Screen Shot 2021-05-18 at 9 01 52 AM
After Screen Shot 2021-05-18 at 9 01 11 AM

Test

  1. Search for a term.
  2. Ensure the scrollbar search highlight bar shows lines where matches are.
  3. Toggle through search results using arrows at the bottom or CtrlOrCmd+G.
  4. Ensure the scrollbar search highlight bar still shows.

Release

  • Fixed search scrollbar highlights so it always shows search matches while in the editor.

@sandymcfadden sandymcfadden added this to the 2.13.0 milestone May 18, 2021
@sandymcfadden sandymcfadden self-assigned this May 18, 2021
@sandymcfadden sandymcfadden requested a review from a team May 18, 2021 12:04
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix 👍

There are still no highlights in preview mode, is that expected?

@sandymcfadden
Copy link
Contributor Author

There are still no highlights in preview mode, is that expected?

It is at this point. Right now the search highlight is handled all through Monaco which isn't used for the preview.

@sandymcfadden sandymcfadden merged commit 14ef91a into develop May 28, 2021
@sandymcfadden sandymcfadden deleted the fix/search-scrollbar-highlights branch May 28, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll Bar Highlights disappear on search if Ctrl+G or > is used to go to next result
2 participants