Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings and other dialogs to use CSS variables for colors #3024

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Update settings and other dialogs to use CSS variables for colors #3024

merged 2 commits into from
Sep 28, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This is a continuation of moving to CSS variables for colors within the app.
This is a large one that updates most of the Settings and other dialogs.

These are the components that have been updated:

  • Panel Title
  • Tab Panels
  • Dialog
  • Button Group
  • Keybindings
  • Settings Group
  • Settings Panels
  • Collaborating
  • Trash Tag Confirmation
  • Unsynchronized Notes

Test

  • Smoke test in light and dark mode
  • Compare between production and this branch
  • Go through the Settings dialogs
  • Ensure they still look the same
  • Open the keybindings dialog
  • Ensure it still looks the same
  • Open the collaborate dialog
  • Ensure it still looks the same
  • Start to delete a tag to open the Trash Tag dialog
  • Ensure it still looks the same
  • Have unsynced notes and try to log out
  • Ensure that the dialog warning still looks the same

Release

  • Updated the Dialogs used throughout the app to use CSS variables for colors

@sandymcfadden sandymcfadden added this to the 2.21.0 milestone Sep 27, 2021
belcherj
belcherj approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested well.

lib/components/tab-panels/style.scss
&:active {
color: var(--background-color);
}
}
}

body[data-theme='light'] .tab-panels__tab-list li.is-active {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels sooo good having this gone.

@sandymcfadden sandymcfadden merged commit cdfd445 into develop Sep 28, 2021
@sandymcfadden sandymcfadden deleted the update/settings-dialogs-css branch September 28, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

@codebykat codebykat Awaiting requested review from codebykat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sandymcfadden @belcherj