Commit c63245c
Address CodeRabbit review feedback
Fixes identified issues:
1. Fix glob expansion bugs (lines 48, 56) - removed quotes around wildcards
2. Update placeholder URL to actual GitHub raw URL
3. Improve .gitignore handling - append to existing file instead of only creating new
4. Add trap for cleanup to ensure temp directory removal even on failure
5. Remove redundant manual cleanup code
Changes:
- Line 48: "$TEMP_DIR/ccpm/"* → "$TEMP_DIR/ccpm"/*
- Line 56: commands/"* → commands/*
- Line 5: Updated URL from placeholder to real GitHub raw URL
- Added cleanup() function with trap EXIT for robust cleanup
- Enhanced .gitignore to append entries if file exists
These changes ensure the installation script is more robust and handles
edge cases properly.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent bf5b5e3 commit c63245c
1 file changed
+28
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
13 | 21 | | |
14 | 22 | | |
15 | 23 | | |
| |||
45 | 53 | | |
46 | 54 | | |
47 | 55 | | |
48 | | - | |
| 56 | + | |
49 | 57 | | |
50 | 58 | | |
51 | 59 | | |
52 | | - | |
| 60 | + | |
53 | 61 | | |
54 | | - | |
55 | 62 | | |
56 | | - | |
| 63 | + | |
57 | 64 | | |
58 | 65 | | |
59 | 66 | | |
| |||
70 | 77 | | |
71 | 78 | | |
72 | 79 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
| 80 | + | |
78 | 81 | | |
79 | | - | |
| 82 | + | |
| 83 | + | |
80 | 84 | | |
81 | | - | |
| 85 | + | |
82 | 86 | | |
83 | 87 | | |
84 | 88 | | |
85 | 89 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | 90 | | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
93 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
94 | 105 | | |
| 106 | + | |
95 | 107 | | |
96 | 108 | | |
97 | 109 | | |
| |||
0 commit comments