Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing history timestamp #104

Open
lightsprint09 opened this issue Jan 21, 2024 · 4 comments
Open

Accessing history timestamp #104

lightsprint09 opened this issue Jan 21, 2024 · 4 comments
Assignees
@heckj
Labels
enhancement New feature or request question Further information is requested upstream dependency The bug, enhancement, etc - has a dependency on the Automerge core library

Comments

@lightsprint09
Copy link
Member

As far as I know, every change encodes a wall clock time stamp. Is this already exposed?
@heckj heckj added the question Further information is requested label Jan 21, 2024
@heckj
Copy link
Collaborator

heckj commented Jan 21, 2024 •
edited
Loading

That's not exposed from the core library (as of version 0.5.7)

@heckj heckj self-assigned this Jan 21, 2024
@heckj
Copy link
Collaborator

heckj commented Jan 21, 2024

/cc @alexjg

@alexjg
Copy link
Collaborator

alexjg commented Jan 21, 2024

It is possible to set the timestamp on a Transaction in the core library, but we are not using transactions here, we are using AutoCommit. I think what we should do is to add a configuration option to AutoCommit to allow you to annotate changes with a timestamp etc. (there are other metadata features we will want soon I think). Once we have that API we can expose the same API in Swift.

@heckj heckj added the enhancement New feature or request label Jan 21, 2024
@alexjg
Copy link
Collaborator

alexjg commented Jan 21, 2024

I've added an issue in the automerge repo here: automerge/automerge#847

@heckj heckj added the upstream dependency The bug, enhancement, etc - has a dependency on the Automerge core library label Mar 12, 2024
@bgomberg bgomberg mentioned this issue Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heckj heckj

Labels
enhancement New feature or request question Further information is requested upstream dependency The bug, enhancement, etc - has a dependency on the Automerge core library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heckj @alexjg @lightsprint09